Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Skip existing packages on twine upload#743

Merged
c24t merged 2 commits intocensus-instrumentation:v0.7.xfrom
c24t:steamroll-twine-failures-more
Aug 2, 2019
Merged

Skip existing packages on twine upload#743
c24t merged 2 commits intocensus-instrumentation:v0.7.xfrom
c24t:steamroll-twine-failures-more

Conversation

@c24t
Copy link
Copy Markdown
Member

@c24t c24t commented Aug 2, 2019

Since we don't change all package version numbers on each release some uploads to PyPI will fail. Skip these with --skip-existing.

See https://circleci.com/gh/census-instrumentation/opencensus-python/2556?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link for an example of a failing build.

@c24t c24t requested review from a team, reyang and songy23 as code owners August 2, 2019 18:32
# Upload the distributions.
for p in dist/* ; do
twine upload $p
twine upload --verbose $p
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use --skip-existing.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's much better, thanks.

Copy link
Copy Markdown
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzchen FYI.

@c24t c24t changed the title Don't report twine upload failure as CI failure Skip existing packages on twine upload Aug 2, 2019
@c24t c24t merged commit 17849f0 into census-instrumentation:v0.7.x Aug 2, 2019
@c24t c24t deleted the steamroll-twine-failures-more branch August 2, 2019 19:49
c24t added a commit to c24t/opencensus-python that referenced this pull request Aug 2, 2019
c24t added a commit to c24t/opencensus-python that referenced this pull request Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants